Fix: Settings panel not reflecting 'Sort by date' on Created Templates view#76108
Open
Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Open
Fix: Settings panel not reflecting 'Sort by date' on Created Templates view#76108Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Mustafabharmal wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When navigating to Site Editor → Templates → Created (the
usertab), templates are correctly sorted by date, but the Settings panel displays "Sort by: Template" instead of "Sort by: Date". The sort dropdown also doesn't offer a Date option.Closes #75136.
Why?
wp_templateis a design post type. TheusePostFieldshook in@wordpress/editorexplicitly excludesdateFieldfor all design post types:Both rendering paths for the template list (legacy router in edit-site and new router in template-list) called
usePostFields({ postType: 'wp_template' })to obtaindateField. This always returnedundefinedfor templates, sodateFieldwas never added to the DataViews fields array. With no registereddatefield, DataViews'SortFieldControlcouldn't reflectview.sort.field === 'date'and fell back to the first available field ("Template").How?
Import
dateFielddirectly from@wordpress/fieldsin both paths, bypassingusePostFields. Push it to the fields array whenactiveView === 'user'(the Created Templates tab), matching the existinggetActiveViewOverridesForTab('user')sort override.Testing instructions
Screenshots or screencast