Playlist: Move getTrackAttributes to utils#76096
Merged
Conversation
Move the `getTrackAttributes` utility function from `edit.js` to a dedicated `utils.js` file in the playlist block directory. This keeps `edit.js` focused on the component logic and avoids exporting utility functions from the edit module. Update the test import to reference the new location. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
scruffian
added
[Type] Code Quality
scruffian
added
[Type] Code Quality
|
Size Change: +24 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTrackAttributesutility function fromedit.jsto a dedicatedutils.jsfile in the playlist block directoryedit.jsfocused on component logic rather than exporting standalone utility functionsThis addresses a review comment from @tyxla on #75203: "This feels like an odd one to export from
edit.js. Should we keep that in a separate file?"Test plan
packages/block-library/src/playlist/test/edit.jsstill pass🤖 Generated with Claude Code