DataForm: fix field label for panel (should not be uppercase)#75944
Open
DataForm: fix field label for panel (should not be uppercase)#75944
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
Contributor
|
I personally prefer this, I find it much more legible. Thank you for the PR. However I want to make sure that concerns shared by @jameskoster and others are accounted for, so we don't just merge this based on my own opinion, but agree on the general path forward. |
|
Size Change: +39 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
Contributor
|
Let's understand what this means for the DS, since (even if the new componentry that @mirka is putting together in Is this different label treatment an dataviews-specific exception? Should we otherwise encode it in the DS? I'm mostly worried about consistency. |
Contributor
|
@ciampo I think the different semantics give us some flexibility here. Since these aren’t actual form That being said, I would also be in favor of removing the all-caps treatment of |
Contributor
|
I like that this change guarantees horizontal alignment between label + value. The all-caps variant is pretty close, but not perfect. It also maintains some design consistency with the Inspector panel which seems beneficial. |
jameskoster
approved these changes
Feb 26, 2026
|
Flaky tests detected in b46eef0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22434084897
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #75730 (comment)
What?
This PR removes the uppercase styles for the field label in the panel layout.
Why?
As per design specs.
How?
Testing Instructions