Skip to content

Components: Specify line-height to avoid inheriting default values #75880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 7 commits into from
Feb 26, 2026
+4 −0
Merged

Components: Specify line-height to avoid inheriting default values #75880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b54f6e
Components: Specify line-height to avoid inheriting default values
aduth Feb 24, 2026
664c8ad
Add CHANGELOG notes
aduth Feb 24, 2026
b304abe
Use line-height: 1 to normalize browser inconsistencies
aduth Feb 25, 2026
f145c48
Use line-height: 1.2 for select styling
aduth Feb 25, 2026
b463052
Add clarifying code comment in select line-height styling
aduth Feb 25, 2026
0955e9a
Use 1.3 as line-height for SelectControl
aduth Feb 26, 2026
f0186e8
FormTokenField: Add code comment clarifying forms styles override
aduth Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
- `ColorPicker`: Preserve hue and saturation when the selected color becomes achromatic ([#75493](https://github.com/WordPress/gutenberg/pull/75493)).
- `SnackbarList`: Fix scaling distortion when a snackbar's content is updated in place via a shared notice ID ([#75709](https://github.com/WordPress/gutenberg/pull/75709)).
- `ToggleGroupControl`: Fix hover styles on disabled items ([#75737](https://github.com/WordPress/gutenberg/pull/75737)).
- `FormTokenField`: Fixed incorrect height of input field when rendered on pages using WordPress 7.0 form styles ([#75880](https://github.com/WordPress/gutenberg/pull/75880)).
- `SelectControl`: Fixed misalignment of option label on some variants when rendered on pages using WordPress 7.0 form styles ([#75880](https://github.com/WordPress/gutenberg/pull/75880)).

### Enhancements

Expand Down
1 change: 1 addition & 0 deletions packages/components/src/form-token-field/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
flex: 1;
font-family: inherit;
font-size: 16px;
line-height: 1; // Override forms.css styles
width: 100%;
max-width: 100%;
margin-left: 4px;
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/select-control/styles/select-control-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export const Select = styled.select< SelectProps >`
cursor: inherit;
display: block;
font-family: inherit;
line-height: 1.3; // Override forms.css styles, large enough value to prevent descender clipping without affecting height
margin: 0;
width: 100%;
max-width: none;
Expand Down
Loading