Skip to content

Plugin: Include Icons assets in ZIP#75866

Merged
mcsf merged 1 commit intotrunkfrom
fix/icons/include-in-plugin-zip
Feb 24, 2026
Merged

Plugin: Include Icons assets in ZIP#75866
mcsf merged 1 commit intotrunkfrom
fix/icons/include-in-plugin-zip

Conversation

@mcsf
Copy link
Contributor

@mcsf mcsf commented Feb 24, 2026

What?

Follow-up of #72215, #71878, #74943

Include in the Gutenberg plugin ZIP file the assets (SVG and manifest.php) of the core library of icons.

Why?

Without these assets, the new Icon block (#71227) won't show any available icons for users of the Gutenberg plugin.

How?

Include the assets in the zip command invocation.

Why now?

This has gone unnoticed so far because, in Gutenberg, all testing happens by building the project from scratch and running the tests in that environment. Meanwhile, in Core, there's a dedicated Gutenberg-to-Core copy process that operates similarly, which explains why this was missed in the backport of the Icons API (Trac). Luckily, @desrosj is experimenting with WordPress/wordpress-develop#11019 and noticed the absence of icons there.

Testing Instructions

  • npm run build:plugin-zip
  • Install the generated gutenberg.zip file in a fresh WordPres site
  • Either:
    • In a new post, add a Icon block, then select Choose icon to reveal the icon library in a modal
    • Ensure the icons are there
  • Or:
    • Check the REST API: /wp/v2/icons

@mcsf mcsf requested a review from ockham February 24, 2026 13:01
@mcsf mcsf added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Block] Icon Affects the Icon block labels Feb 24, 2026
@mcsf mcsf requested a review from ryanwelcher February 24, 2026 13:04
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the issue on a fresh WordPress install, using GB 22.6.0 RC2

Then tested the fix by using the asset produced by CI for the "Build Release Artifact" workflow on this PR ✅

LGTM 🚢

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ockham ockham added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 24, 2026
@mcsf mcsf merged commit 70f4b7c into trunk Feb 24, 2026
56 of 57 checks passed
@mcsf mcsf deleted the fix/icons/include-in-plugin-zip branch February 24, 2026 13:30
@github-actions github-actions bot added this to the Gutenberg 22.7 milestone Feb 24, 2026
desrosj added a commit to desrosj/wordpress-develop that referenced this pull request Feb 24, 2026
The Gutenberg repository has been updated to include the icon assets in the plugin build. See github.com/WordPress/gutenberg/pull/75866.
@ockham ockham modified the milestones: Gutenberg 22.7, Gutenberg 22.6 Feb 24, 2026
ockham added a commit that referenced this pull request Feb 24, 2026
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
@ockham
Copy link
Contributor

ockham commented Feb 24, 2026

I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 91c66f3

@ockham ockham removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Icon Affects the Icon block [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants