Conversation
ockham
left a comment
There was a problem hiding this comment.
Reproduced the issue on a fresh WordPress install, using GB 22.6.0 RC2 ✅
Then tested the fix by using the asset produced by CI for the "Build Release Artifact" workflow on this PR ✅
LGTM 🚢
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The Gutenberg repository has been updated to include the icon assets in the plugin build. See github.com/WordPress/gutenberg/pull/75866.
Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 91c66f3 |
What?
Follow-up of #72215, #71878, #74943
Include in the Gutenberg plugin ZIP file the assets (SVG and manifest.php) of the core library of icons.
Why?
Without these assets, the new Icon block (#71227) won't show any available icons for users of the Gutenberg plugin.
How?
Include the assets in the
zipcommand invocation.Why now?
This has gone unnoticed so far because, in Gutenberg, all testing happens by building the project from scratch and running the tests in that environment. Meanwhile, in Core, there's a dedicated Gutenberg-to-Core copy process that operates similarly, which explains why this was missed in the backport of the Icons API (Trac). Luckily, @desrosj is experimenting with WordPress/wordpress-develop#11019 and noticed the absence of icons there.
Testing Instructions
npm run build:plugin-zipgutenberg.zipfile in a fresh WordPres site/wp/v2/icons