Cross-origin isolation tests: Try enabling client-side media processing explicitly for the e2e test suite#75763
Closed
andrewserong wants to merge 2 commits intotrunkfrom
Closed
Conversation
… suite instead, that way we can continue testing that the feature works
andrewserong
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
Member
|
I think the undo test is still flaky even after - #75740. |
Contributor
Author
|
And the other e2es are still failing, too. I'll just spend a few mins looking into it, and otherwise will put up a separate PR to just skip the suite. |
Member
|
We could also skip this test and re-enable it alongside the feature. |
Contributor
Author
Yeah, I think that's the simpler approach for now. I can take a look at some of this with fresh eyes next week. For now, I've opened #75764 to just skip the test. Thanks for the back and forth! |
Contributor
Author
|
Closing in favour of #75764 |
Mamaduka
deleted the
update/skip-cross-origin-isolation-e2e-tests-for-now
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follows:
Try explicitly enabling the client-side media processing for the cross origin isolation e2e tests
Why?
With #75756 we're defaulting to the client-side media processing feature being disabled, however it would still be good to ensure this feature is covered via tests.
If this PR feels flaky (or doesn't work) an alternative would be to skip the suite entirely for now.
How?
Testing Instructions
See if the e2es pass