Skip to content

Navigation: Update overlay template part naming to 'Navigation Overlay' #75564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 1 commit into from
Feb 16, 2026
+21 −21
Merged

Navigation: Update overlay template part naming to 'Navigation Overlay' #75564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions packages/block-library/src/navigation/edit/test/use-create-overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ describe( 'useCreateOverlayTemplatePart', () => {
it( 'should save a new overlay with correct parameters when no overlays exist', async () => {
const overlayTemplateParts = [];
const createdOverlay = {
id: 'twentytwentyfive//overlay',
id: 'twentytwentyfive//navigation-overlay',
theme: 'twentytwentyfive',
slug: 'overlay',
slug: 'navigation-overlay',
title: {
rendered: 'Overlay',
rendered: 'Navigation Overlay',
},
area: 'navigation-overlay',
};
Expand All @@ -117,8 +117,8 @@ describe( 'useCreateOverlayTemplatePart', () => {
'postType',
'wp_template_part',
expect.objectContaining( {
slug: 'overlay',
title: 'Overlay',
slug: 'navigation-overlay',
title: 'Navigation Overlay',
content: expect.any( String ),
area: 'navigation-overlay',
} ),
Expand All @@ -129,21 +129,21 @@ describe( 'useCreateOverlayTemplatePart', () => {

it( 'should generate unique title when overlays already exist', async () => {
const existingOverlay = {
id: 'twentytwentyfive//overlay',
id: 'twentytwentyfive//navigation-overlay',
theme: 'twentytwentyfive',
slug: 'overlay',
slug: 'navigation-overlay',
title: {
rendered: 'Overlay',
rendered: 'Navigation Overlay',
},
area: 'navigation-overlay',
};
const overlayTemplateParts = [ existingOverlay ];
const createdOverlay = {
id: 'twentytwentyfive//overlay-2',
id: 'twentytwentyfive//navigation-overlay-2',
theme: 'twentytwentyfive',
slug: 'overlay-2',
slug: 'navigation-overlay-2',
title: {
rendered: 'Overlay 2',
rendered: 'Navigation Overlay 2',
},
area: 'navigation-overlay',
};
Expand All @@ -158,13 +158,13 @@ describe( 'useCreateOverlayTemplatePart', () => {
await createOverlayTemplatePart.current();
} );

// Verify it generates a unique title (Overlay 2) when Overlay already exists
// Verify it generates a unique title (Navigation Overlay 2) when Navigation Overlay already exists
expect( mockSaveEntityRecord ).toHaveBeenCalledWith(
'postType',
'wp_template_part',
expect.objectContaining( {
title: 'Overlay 2',
slug: 'overlay-2',
title: 'Navigation Overlay 2',
slug: 'navigation-overlay-2',
content: expect.any( String ),
area: 'navigation-overlay',
} ),
Expand All @@ -175,11 +175,11 @@ describe( 'useCreateOverlayTemplatePart', () => {
it( 'should use pattern content when pattern is found', async () => {
const overlayTemplateParts = [];
const createdOverlay = {
id: 'twentytwentyfive//overlay',
id: 'twentytwentyfive//navigation-overlay',
theme: 'twentytwentyfive',
slug: 'overlay',
slug: 'navigation-overlay',
title: {
rendered: 'Overlay',
rendered: 'Navigation Overlay',
},
area: 'navigation-overlay',
};
Expand Down Expand Up @@ -212,11 +212,11 @@ describe( 'useCreateOverlayTemplatePart', () => {
it( 'should use empty paragraph when pattern is not found', async () => {
const overlayTemplateParts = [];
const createdOverlay = {
id: 'twentytwentyfive//overlay',
id: 'twentytwentyfive//navigation-overlay',
theme: 'twentytwentyfive',
slug: 'overlay',
slug: 'navigation-overlay',
title: {
rendered: 'Overlay',
rendered: 'Navigation Overlay',
},
area: 'navigation-overlay',
};
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/edit/use-create-overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function useCreateOverlayTemplatePart( overlayTemplateParts ) {
( templatePart ) => templatePart.title?.rendered
);
const uniqueTitle = getUniqueTemplatePartTitle(
__( 'Overlay' ),
__( 'Navigation Overlay' ),
templatePartsWithTitles
);
const cleanSlug = getCleanTemplatePartSlug( uniqueTitle );
Expand Down
Loading