Skip to content

Fix auto draft bug for Y.text titles #75560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ingeniumed merged 2 commits into from
Feb 16, 2026
+23 −1
Merged

Fix auto draft bug for Y.text titles #75560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4c802b
Fix the auto draft but for Y.text titles and add a test for it
ingeniumed Feb 16, 2026
15b451d
Simplify the check
ingeniumed Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core-data/src/utils/crdt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export function applyPostChangesToCRDTDoc(
// Draft" template title is not synced.
if (
key === 'title' &&
! currentValue &&
! currentValue?.toString() &&
'Auto Draft' === rawValue
) {
rawValue = '';
Expand Down
22 changes: 22 additions & 0 deletions packages/core-data/src/utils/test/crdt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,28 @@ describe( 'crdt', () => {
expect( title?.toString() ).toBe( '' );
} );

it( 'skips "Auto Draft" template title when current value is empty Y.Text', () => {
// First set an empty title (simulates a prior sync that cleared it).
applyPostChangesToCRDTDoc(
doc,
{ title: '' } as PostChanges,
mockPostType
);

const title = map.get( 'title' );
expect( title ).toBeInstanceOf( Y.Text );
expect( title?.toString() ).toBe( '' );

// Now sync "Auto Draft" — should still be suppressed.
applyPostChangesToCRDTDoc(
doc,
{ title: 'Auto Draft' } as PostChanges,
mockPostType
);

expect( map.get( 'title' )?.toString() ).toBe( '' );
} );

it( 'handles excerpt with RenderedText format', () => {
const changes = {
excerpt: {
Expand Down
Loading