Skip to content

Block Lock: Disable Apply button on non-dirty state #75495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 4 commits into from
Feb 16, 2026
Merged

Block Lock: Disable Apply button on non-dirty state #75495

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d28997
Block Lock: Disable Apply button on non-dirty state
ramonjd Feb 13, 2026
02379bd
Revert useState initialization change
ramonjd Feb 13, 2026
5c39f3e
Remove unnecessary useMemo for isDirty check
ramonjd Feb 16, 2026
709510e
Bail out of form submission when not dirty
ramonjd Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-editor/src/components/block-lock/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ export default function BlockLockModal( { clientId, onClose } ) {
const isAllChecked = Object.values( lock ).every( Boolean );
const isMixed = Object.values( lock ).some( Boolean ) && ! isAllChecked;

const isDirty =
lock.move !== isMoveLocked ||
lock.remove !== isRemoveLocked ||
( allowsEditLocking && lock.edit !== isEditLocked ) ||
( hasTemplateLock && applyTemplateLock !== !! templateLock );

return (
<Modal
title={ sprintf(
Expand All @@ -90,6 +96,9 @@ export default function BlockLockModal( { clientId, onClose } ) {
<form
onSubmit={ ( event ) => {
event.preventDefault();
if ( ! isDirty ) {
return;
}
updateBlockAttributes( [ clientId ], {
lock,
templateLock: applyTemplateLock
Expand Down Expand Up @@ -224,6 +233,8 @@ export default function BlockLockModal( { clientId, onClose } ) {
<Button
variant="primary"
type="submit"
disabled={ ! isDirty }
accessibleWhenDisabled
__next40pxDefaultSize
>
{ __( 'Apply' ) }
Expand Down
Loading