Notes: Conditionally restore default sidebar#75455
Open
Conversation
Mamaduka
added
[Type] Enhancement
|
Size Change: +16 B (0%) Total Size: 3.02 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/notes-restore-default-sidebar
branch
from
e89b958 to
ded41b6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 12, 2026
| if ( | ||
| getActiveComplementaryArea( 'core' ) === FLOATING_NOTES_SIDEBAR | ||
| ) { | ||
| disableComplementaryArea( 'core', FLOATING_NOTES_SIDEBAR ); |
Member
Author
There was a problem hiding this comment.
The disableComplementaryArea only accepts one argument, which I forgot. Should be fixed now.
t-hamano
reviewed
Feb 12, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! This may require some complex processing, but I think at least the following two behaviours need to be fixed.
- If the sidebar was closed, I don't think it should open when the form is canceled.
f3abb87900a729d22abd66309e026e55.mp4
- If a post has unresolved notes, the sidebar will not be restored when the form is canceled.
3d9de5563126aaff046e0964ae4ab4f8.mp4
Member
Author
I think that's correct behavior. User added a note, so they probably want to keep the sidebar open. We only restore the default sidebar if the first new note form was closed.
Good point, but this is where it gets tricky 😄 I'll see what I can do :) |
Contributor
|
I think it's difficult to determine whether the current behavior is a bug, so if we can't find an ideal solution, we may be able to close it as "not a bug." 😅 |
Member
Author
|
Generally speaking, I don't think it's a bug. That's how Sidebars behave. IMO, it only feels odd because the floating sidebar gets special treatment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #75450.
PR updates logic in
useEnableFloatingSidebarto reopen the default document sidebar when the floating notes sidebar is no longer enabled.Why?
A small QoL improvement.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-02-12.at.11.52.44.mp4