Set snackbar position to center #75294
+21
−30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,5 @@ | |
| } | ||
|
|
||
| .boot-layout .boot-notices__snackbar { | ||
| @include snackbar-container(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,13 +120,6 @@ | |
| isolation: isolate; | ||
| } | ||
|
|
||
| .edit-post-layout__snackbar { | ||
|
Contributor
There was a problem hiding this comment. It seems like there are no elements with this class anywhere, so if that's the case, we can remove this selector entirely. Perhaps this class was removed as part of the work to unify the editor packages.
Contributor
Author
There was a problem hiding this comment. This class is present in this file: gutenberg/packages/edit-post/src/components/layout/index.js Lines 624 to 625 in 7f3782d
Contributor
There was a problem hiding this comment. The code should not be in the trunk branch. https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-post/src/components/layout/index.js |
||
| @include snackbar-container(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,6 @@ | |
| @use "@wordpress/base-styles/variables" as *; | ||
|
|
||
| .edit-widgets-notices__snackbar { | ||
| @include snackbar-container(); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing unnecessary selectors, we may only need to apply this mixin in one or two places. If that's the case, we can just hard-code the styles where needed without removing the mixin.
I also want to avoid exposing public mixins as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be misunderstanding, but the position of the SnackbarNotices component isn’t technically hardcoded. The consumer is responsible for defining the CSS container that determines where the snackbar appears. The mixin was introduced to avoid duplicating the same styling logic across multiple files.