Support zip theme sources in Playground runtime #75155
Merged
+7
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ObliviousHarmony and
t-hamano
as code owners
youknowriad
requested review from
a team and
sirreal
and removed request for
a team
youknowriad
added
[Type] Bug
youknowriad
commented
Feb 2, 2026
| // Mount themes | ||
| // All theme types (local, git, zip) can be mounted after downloading/extraction | ||
| for ( const theme of envConfig.themeSources || [] ) { | ||
| if ( theme.type === 'local' || theme.type === 'git' ) { |
Contributor
Author
There was a problem hiding this comment.
This was just unnecessary.
Allow zip archive themes to be mounted in Playground runtime, matching Docker runtime behavior. After download and extraction, zip themes have a path property that can be mounted like local and git themes. Fixes #75140 https://claude.ai/code/session_016DZPQdYCKRcYKh42Y6MX3h
youknowriad
force-pushed
the
claude/fix-docker-runtime-reuse-40biF
branch
from
8b62e79 to
7febf31
Compare
andrewserong
approved these changes
Feb 2, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing well for me — I assume in the testing instructions, you mean testing the themes array in .wp-env.override.json, including a zip, a local theme, and a git-based theme? All three are working for me 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @claude. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Awesome thank you :) |
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7febf31. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21608647781
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75140
What?
Enable mounting of zip-based theme sources in the Playground runtime by removing the type restriction that previously only allowed local and git themes.
Why?
The current implementation throws an error when attempting to use zip-based theme sources, limiting the flexibility of theme deployment options. Since the theme extraction/downloading is handled before the mount operation, all theme types (local, git, and zip) can be mounted using the same
--mount-dirapproach after their files are prepared.How?
Simplified the
getMountArgs()function inblueprint-builder.jsby:This change assumes that theme sources are already downloaded/extracted before reaching this mount stage, making the type-specific handling unnecessary.
Testing Instructions
/wordpress/wp-content/themes/{theme-basename}https://claude.ai/code/session_016DZPQdYCKRcYKh42Y6MX3h