Rely solely on new URL for link control url validation #75149
+21
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In Add URL validation in LinkControl using ValidatedInputControl #73486 we said we were relying on
new URLto validate URLs, but this isn't entirely true. We are usingisURLLiketo filter out some URLs that would pass thenew URLconstructor (URLs with spaces, for example, get converted to%20) and we also allow hash links and fragments to skip thenew URLcheck. Not only that, but we call hash links with duplicate#invalid, butnew URLpasses these and it does technically work.I noticed that
prependHTTPS's flow is toprependHTTPthen replacehttpwithhttps. Since we're defaulting tohttpsmore, the easiest way to improve this is to switch that. HaveprependHTTPrely on replacinghttpswithhttp.Why?
I'm not sure this is the right direction, but wanted to open the discussion to get consistency.
How?
Rely solely on
new URLfor consistency.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast