Image block: Add missing space between sentences #75142
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has only gone unnoticed because the second sentence starts with opening parenthesis, which is enough to let the browser break the line at that point. However, I'd argue this still needs fixing: - It could break in locales in which the string is rendered with a different glyph that doesn't allow the line to break. - It can (and has) set the wrong precedent.
mcsf
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Feb 2, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
LGTM, and if I manually hack in the removal of the ( character, then the space is working as expected too:
I notice that elsewhere when using <ExternalLink> we've used createInterpolateElement to ensure spacing when injecting that component into a string of text. I don't think it's necessary here as the { ' ' } seems to work just fine, but thought I'd mention it just in case.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Image block's advanced controls, under Title Attribute, add a space separating the sentence "Describe the role of this image on the page." and "(Note: many devices and browsers do not display this text.)".
This has only gone unnoticed because the second sentence starts with opening parenthesis, which is enough to let the browser break the line at that point. However, I'd argue this still needs fixing:
With no parentheses, we would see: