ui/Button: add min width
#75133
Open
ui/Button: add min width
#75133
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
force-pushed
the
feat/button-min-width
branch
from
aa2bf0f to
15be33d
Compare
ciampo
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
Contributor
Author
|
I guess one question is whether we want to apply similar changes to the |
aduth
approved these changes
Feb 2, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM from a technical perspective 👍
On the question of @wordpress/component's Button parity, it's probably low risk and we should try to keep the styles in sync, though as an enhancement it feels within reason that we could limit this to the new implementation as an opt-in.
Contributor
|
I like the video, thanks for doing this. I'll defer to Andrew and Jay if he chimes in on technical pieces, though ask about this one: Should this be a CSS variable? Is this how an implementer should change the min-width? Or should they not change the min-width from the default 4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #74415
Add a minimum switch to the
Buttoncomponent in the@wordpress/uipackageWhy?
For better UI balance, especially when buttons with very short labels are paired with button with longer labels
How?
By adding a
min-widthCSS property:chunit, ie. it is explicitely related to the amount of charactersunstyledvariantsIconButtoncomponentTesting Instructions
Play around in Storybook, changing the label text
Screenshots or screencast
Kapture.2026-02-02.at.14.20.10.mp4