Build: Fix glob ignore patterns in dot-prefixed directories #75114
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `dot: true` option to fast-glob calls in transpilePackage to ensure ignore patterns (like `**/*.native.*`) work correctly when the repository path contains directories starting with a dot, such as `.worktrees/`. Without this option, fast-glob's ignore patterns fail to match files inside dot-prefixed directories, causing platform-specific files (`.native.js`, `.ios.js`, `.android.js`) to be incorrectly included in web builds. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 0482efe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21549585758
|
aduth
reviewed
Feb 2, 2026
Member
There was a problem hiding this comment.
Given the use-case described in #75113, I wonder if it might be better to use the cwd option to set the packageDir, so that the glob pattern doesn't include the full absolute path that trips this dot behavior.
Something like...
const srcFiles = await glob(
`src/**/*.${ SOURCE_EXTENSIONS }`,
{
ignore: IGNORE_PATTERNS,
cwd: packageDir,
},
);(We may not even need normalizePath if we make the change, since it's only needed to address a requirement of fast-glob patterns)
I admit to not being aware of this default dot file behavior in fast-glob, but I could see some value if it mitigates a risk of someone's internal files (sensitive configuration, etc.) from being accidentally included in the built / published npm artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dot: trueto fast-glob calls intranspilePackageProblem
When the repository path contains a dot-prefixed directory (e.g.,
.worktrees/),fast-glob's ignore patterns fail to match, causing
.native.jsfiles to beincorrectly included in web builds.
Fixes #75113
Test Plan
.worktrees/directorynpm run build🤖 Generated with Claude Code