-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix tabIndex prop handling in Tabs test helpers #75067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
react => @wordpress/elements import order
This reverts commit 9ef48ac.
Instead of using `?? 0` which was a workaround for JSDOM, the proper fix is to only pass the tabIndex prop when it's explicitly defined. This allows Base UI's default tabIndex behavior (0 for visible panels, -1 for hidden) to work correctly when no custom tabIndex is specified. Co-authored-by: ciampo <1083581+ciampo@users.noreply.github.com>
Address code review feedback by updating the remaining instance of direct tabIndex assignment to use the same conditional spreading pattern for consistency. Co-authored-by: ciampo <1083581+ciampo@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Copilot. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
5d3c3cd to
afcac15
Compare
|
@copilot rebase on top ot the base PR and solve conflicts |
I've successfully rebased the branch on top of Current state:
Challenge: The proper resolution would be |
?? 0workaround in test codetabIndex={undefined}overrides Base UI defaults💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.