Blocks: Try prepending 'https' to URLs without protocol #75005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @WDWNT-Frank, @porg. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Jan 28, 2026
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Internal dependencies | |||
| * WordPress dependencies | |||
Member
Author
There was a problem hiding this comment.
This positioning swap was requested by the linter.
Mamaduka
force-pushed
the
update/blocks-prepend-schema
branch
from
13183a7 to
eef202d
Compare
|
Size Change: +6 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
update/blocks-prepend-schema
branch
from
eef202d to
4df45da
Compare
Contributor
|
Could we change the prependHTTP to prependHTTPS for Link Control direct entry on this PR as well? |
|
Flaky tests detected in ffebc26. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21515152130
|
adamsilverstein
pushed a commit
that referenced
this pull request
Jan 31, 2026
Unlinked contributors: WDWNT-Frank, porg. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #46244.
PR replaces
prependHTTPcalls withprependHTTPS. URLs without a protocol now will usehttps.P.S. I know Nav blocks are still using
prependHTTP, but it's only for internal check and not for storing modified attribute.Why?
It's 2026, and most external services should be using
https.Testing Instructions
The changes have e2e test coverage.