e2e: fix flaky tests for settings sidebar #74929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 3.1 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 93cb449. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21331868275
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SirLouen
approved these changes
Jan 25, 2026
Member
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
✅ Reviewed and tested, looking good
Member
|
Thanks for the fix, @t-hamano!
I was also looking into this on Friday. The following seems like a bug to me, so maybe we have to look into the Tab component. cc @WordPress/gutenberg-components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48878
What?
Fixes a recently flaky e2e test for the settings sidebar.
Example:
Why?
Looking at the log, it seems that
aria-selectedistruefor both tabs "Template" and "Block".Perhaps the moment the Block tab is selected instead of the Template tab, aria-selected becomes true for both tabs.
How?
Make the assertion more strict: instead of checking the selected tab text, check the selection state of each tab instead.
Testing Instructions
All CI checks should be ✅