Skip to content

E2e tests: remove switchToLegacyCanvas from multi select and a11y suite #74845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 1 commit into from
Jan 22, 2026
Merged

E2e tests: remove switchToLegacyCanvas from multi select and a11y suite #74845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions test/e2e/specs/editor/various/a11y.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@ test.describe( 'a11y (@firefox, @webkit)', () => {
pageUtils,
editor,
} ) => {
// To do: run with iframe.
await editor.switchToLegacyCanvas();

// On a new post, initial focus is set on the Post title.
await expect(
page.locator( 'role=textbox[name=/Add title/i]' )
editor.canvas.locator( 'role=textbox[name=/Add title/i]' )
).toBeFocused();
// Navigate to the 'Editor settings' region.
await pageUtils.pressKeys( 'ctrl+`' );
Expand All @@ -50,11 +47,7 @@ test.describe( 'a11y (@firefox, @webkit)', () => {
test( 'should constrain tabbing within a modal', async ( {
page,
pageUtils,
editor,
} ) => {
// To do: run with iframe.
await editor.switchToLegacyCanvas();

// Open keyboard shortcuts modal.
await pageUtils.pressKeys( 'access+h' );

Expand Down
9 changes: 2 additions & 7 deletions test/e2e/specs/editor/various/multi-block-selection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,9 +1252,6 @@ test.describe( 'Multi-block selection (@firefox, @webkit)', () => {
page,
editor,
} ) => {
// To do: run with iframe.
await editor.switchToLegacyCanvas();

await editor.insertBlock( {
name: 'core/paragraph',
attributes: { content: '<strong>1</strong>[' },
Expand All @@ -1264,7 +1261,7 @@ test.describe( 'Multi-block selection (@firefox, @webkit)', () => {
attributes: { content: ']2' },
} );
// Focus and move the caret to the end.
const secondParagraphBlock = page
const secondParagraphBlock = editor.canvas
.getByRole( 'document', { name: 'Block: Paragraph' } )
.filter( { hasText: ']2' } );
const secondParagraphBlockBox =
Expand All @@ -1277,9 +1274,7 @@ test.describe( 'Multi-block selection (@firefox, @webkit)', () => {
} );

await page.keyboard.press( 'ArrowLeft' );
const strongText = page
.getByRole( 'region', { name: 'Editor content' } )
.getByText( '1', { exact: true } );
const strongText = editor.canvas.getByText( '1', { exact: true } );
const strongBox = await strongText.boundingBox();
// Focus and move the caret to the end.
await strongText.click( {
Expand Down
Loading