Block Bindings: Fix 'useSelect' warnings for attribute controls#74571
Open
Block Bindings: Fix 'useSelect' warnings for attribute controls#74571
Conversation
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +200 B (+0.01%) Total Size: 3.1 MB
ℹ️ View Unchanged
|
Member
Author
|
It looks like running |
Contributor
Thanks for your help @Mamaduka . As far as I remember, it is a long standing issue as the fields list can be updated at any time. There has been some discussion about it: |
Member
Author
|
Yeah, there are always limitations with similar optimization hacks. This got me wondering: maybe we need a better, more general selector for block types. Considering that we have to resolve similar optimizations more often than not. It might be a good idea to revisit current private selectors, how they're used and where we're "hitting the wall". |
Contributor
|
Yeah, working with this code has been very frustrating in the past. There's a whole history of (ultimately failed) attempts (e.g. #65604, #67885, and #72109)). I thought that #72974 and #73579 finally managed to fix all related issues and get rid of the warning, but alas.
Yeah, makes sense (although I'm not quite sure what that would need to look like). I'm not sure this particular issue is due to how we organize private selectors; block bindings might be somewhat uniquely problematic as their API expects users to pass functions (such as |
stokesman
force-pushed
the
fix/attribute-control-comp-selectors
branch
from
e1d4d3c to
e655f49
Compare
Contributor
I’m thinking that the stale values aren’t necessarily due to the memo, but that the results of It seems right to derive In the changes I pushed here, I tried including a string key formed from all the field keys and and source names in the return from the |
|
Flaky tests detected in e655f49. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21378542992
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #73579.
PR refactors values returned by the
useSelecthook inBlockBindingsAttributeControlcomponent and fixes the warning. Now thecompatibleFieldsis derived outside themapSelectcallback.Testing Instructions
Screenshots or screencast