@wordpress/ui Button: undo destructive tone variant
#74540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d190fc7.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Enhancement
Contributor
Author
|
I'll go ahead and merge without waiting for a review, since these changes were agreed in #74463 (comment) |
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
Remove recently added
destructivetone variant for theButtoncomponent in the@wordpress/uipackage.Why?
TL;DR: the destructive variant shouldn't be wildely available via the
Buttoncomponent, and should be reserved only for specific buttons rendered inside theDialogcomponent (coming soon).See #74463 (comment) for more context.
How?
Undid changes from #74463
Testing Instructions
Smoke test Storybook, make sure everything behaves as normal and that the
destructivetone is completely removed.