UI: Add Icon component
#74311
Merged
UI: Add Icon component
#74311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b707d57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20642807566
|
aduth
approved these changes
Jan 2, 2026
| * ``` | ||
| */ | ||
| export const Icon = forwardRef< SVGSVGElement, IconProps >( function Icon( | ||
| { icon, size = 24, ...restProps }, |
Member
There was a problem hiding this comment.
Random thought: icon feels like it's mostly identical in purpose to the render prop in how it functions. I feel like icon is a more intuitive name, though maybe there'd be some benefit in using the useRender hook to manage its rendering? Then again, this doesn't feel very complex as it is.
| @@ -0,0 +1,30 @@ | |||
| import { forwardRef } from '@wordpress/element'; | |||
| import { SVG } from '@wordpress/primitives'; | |||
Member
There was a problem hiding this comment.
I'm not sure what the plans are with the native editor, but given past mentions of it being "paused" and ongoing development of GutenbergKit, do we think we'll need this primitive, or could we start with a plain <svg /> ?
Member
Author
There was a problem hiding this comment.
As best as I could assess, removal of the SVG component should be done in a way that's coordinated across the codebase, not just in the Icon component. I find three separate concerns that need to be considered:
- React Native (things breaking in the shipping WordPress/Jetpack mobile apps).
- Mandatory addition of a
aria-hidden="true". - The lint rule that enforces the above two concerns on every
svgin the codebase.
So in any case this will be outside the scope of this PR.
Can @WordPress/native-mobile confirm the first point, whether or not we're ready to remove the React Native compatibility for svgs?
Member
There was a problem hiding this comment.
The mobile team is working to ship GutenbergKit to mobile users. Once achieved, we'll be ready to remove React Native-related logic. I suggest waiting for that and agree that it should be coordinated across the codebase rather than just the Icon component.
Member
Author
There was a problem hiding this comment.
@dcalhoun Thanks for confirming! We'll wait for that.
# Conflicts: # packages/ui/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #74178
What?
Add
Iconcomponent to@wordpress/ui.Why?
This is a replacement for the
Iconcomponent in@wordpress/components, with these changes:SVGs from@wordpress/primitives.fill="currentColor".Testing Instructions
See stories in Storybook.
Screenshots or screencast