Update dataviews readme with new pickerTable layout.#73372
Update dataviews readme with new pickerTable layout.#73372tellthemachines merged 2 commits intotrunkfrom
Conversation
|
No, I don't think this needs a changelog entry 😂 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
left a comment
There was a problem hiding this comment.
Oh good catch, thanks for updating the docs! LGTM
| pickerGrid: { | ||
| showMedia: true, | ||
| }, | ||
| pickerTable: { | ||
| showMedia: false, | ||
| }, |
There was a problem hiding this comment.
This is such an insignificant note that I want to say "please ignore this comment" before I even type it out! But for this example, I'd probably go with showMedia: true on each of the layouts and showTitle: false on grid, and showTitle: true on the table layout. Anyway, just a thought!
There was a problem hiding this comment.
Hmm both these properties are true by default so we don't really need to set them; I think this started out as a contrived example for the dataviews defaultLayouts.
We could instead go with a more realistic example like
pickerGrid: {
showTitle: false,
},
pickerTable: {},
|
Flaky tests detected in afae715. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19451518156
|
What?
Follow-up from #72914.
Adds info about new picker layout type to dataviews readme.