Skip to content

Update dataviews readme with new pickerTable layout.#73372

Merged
tellthemachines merged 2 commits intotrunkfrom
update/picker-table-readme
Nov 18, 2025
Merged

Update dataviews readme with new pickerTable layout.#73372
tellthemachines merged 2 commits intotrunkfrom
update/picker-table-readme

Conversation

@tellthemachines
Copy link
Contributor

What?

Follow-up from #72914.

Adds info about new picker layout type to dataviews readme.

@tellthemachines tellthemachines self-assigned this Nov 18, 2025
@tellthemachines tellthemachines added [Type] Developer Documentation Documentation for developers [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 18, 2025
@tellthemachines
Copy link
Contributor Author

No, I don't think this needs a changelog entry 😂

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks for updating the docs! LGTM

Comment on lines 632 to 637
pickerGrid: {
showMedia: true,
},
pickerTable: {
showMedia: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such an insignificant note that I want to say "please ignore this comment" before I even type it out! But for this example, I'd probably go with showMedia: true on each of the layouts and showTitle: false on grid, and showTitle: true on the table layout. Anyway, just a thought!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm both these properties are true by default so we don't really need to set them; I think this started out as a contrived example for the dataviews defaultLayouts.

We could instead go with a more realistic example like

pickerGrid: {
		showTitle: false,
	},
	pickerTable: {},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@github-actions
Copy link

Flaky tests detected in afae715.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19451518156
📝 Reported issues:

@tellthemachines tellthemachines merged commit e6269cb into trunk Nov 18, 2025
35 of 36 checks passed
@tellthemachines tellthemachines deleted the update/picker-table-readme branch November 18, 2025 03:02
@github-actions github-actions bot added this to the Gutenberg 22.2 milestone Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants