Merged
Conversation
youknowriad
commented
Nov 8, 2025
| ? focusOnMountRef | ||
| : null, | ||
| ] ) } | ||
| className="components-modal__children-container" |
Contributor
Author
There was a problem hiding this comment.
It's a bit challenging to do a 100% full screen modal where the content's height matches the modal's height. This additional class allows us to do this. I know it's not great but it's not worse than how we've been using modal before.
Member
Contributor
Author
There was a problem hiding this comment.
Agreed this deserves its own prop or something like that.
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.44 kB (+0.06%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
Member
|
@youknowriad I think if we actually display a proper tab for JS code we need to properly handle whether or not that user ca actually do this or not. By default only admin roles have the capability to save unfiltered_html in the content. So for all other roles this JS code will just get filtered out (for good reasons 👀) |
Contributor
Author
|
@fabiankaegy Makes sense, I'll add the check :) |
|
Flaky tests detected in 7a258a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19202696057
|
Contributor
Author
|
I think this is looking great. thanks for the updates @mtias |
mtias
approved these changes
Nov 9, 2025
Contributor
|
That was fast! Nice. |
6 tasks
Contributor
|
Just noticed a scrollbar issues / some visual bugs for when there's enough content to cause a scrollbar to be present. I've put up a potential fix in #73506 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #73106
What?
Redesigns the HTML block editing experience with a modal-based editor featuring separate tabs for HTML, CSS, and JavaScript and move to a modal (more details on the issue).
How?
Modal-based editing with vertical tabs
Content parsing and serialization
To achieve the tabs separation, we parse/serialize style and script tab by using data attributes to separate the "controlled" style/JS from the uncontrolled ones.
Testing Instructions