Reduce inspector subscriptions by not subscribing if panel is not enabled#73013
Merged
Reduce inspector subscriptions by not subscribing if panel is not enabled#73013
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
9 tasks
|
Flaky tests detected in 4747822. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19148052756
|
Mamaduka
approved these changes
Nov 6, 2025
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Uses the existing isEnabled check to not subscribe to the store when the currently selected block does not have access to that panel.
Why?
Minor perf, but it adds up.
How?
If the panel is not enabled and will return null, don't subscribe to the store. I didn't add the dimensions panel here, as that work is done in Perf: Only mount SpacingVisualizers when actively visualizing
Testing Instructions
Everything should work the same as on trunk. Look for errors in the inspector panel.
Testing Instructions for Keyboard
Screenshots or screencast