Update: Label of "Move to trash" action to "Trash".#72596
Merged
jorgefilipecosta merged 2 commits intotrunkfrom Oct 23, 2025
Merged
Update: Label of "Move to trash" action to "Trash".#72596jorgefilipecosta merged 2 commits intotrunkfrom
jorgefilipecosta merged 2 commits intotrunkfrom
Conversation
jameskoster
approved these changes
Oct 23, 2025
Contributor
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Approving on the assumption that this also applies to Templates.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -9 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1241e75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18744708657
|
jorgefilipecosta
deleted the
update/move-to-trash-to-trash-action-name
branch
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 23, 2025
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: hanneslsm <hanneslsm@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 289102f |
tyxla
reviewed
Oct 31, 2025
| const trashPost: Action< PostWithPermissions > = { | ||
| id: 'move-to-trash', | ||
| label: __( 'Move to trash' ), | ||
| label: __( 'Trash' ), |
Member
There was a problem hiding this comment.
This needs to become _x( 'Trash', 'verb' ) because Trash can be a verb and a noun, and in many languages it makes a difference.
Member
There was a problem hiding this comment.
Would also help to reuse the same translation from further down in the same file.
Follow-up at #73704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #72539
Updates the label of "Move to trash" action to "Trash".
Testing Instructions
Go to /wp-admin/site-editor.php?p=%2Fpage
Hover a page and very the action to tash is labeled as "Trash".
Select multiple pages and verify the action is still labeled "Trash".