Pattern Overrides: Add support for Image caption attribute#72476
Merged
Pattern Overrides: Add support for Image caption attribute#72476
Conversation
ockham
added
[Type] Enhancement
|
Size Change: -10 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
ockham
force-pushed
the
add/pattern-overrides-support-for-image-caption-attribute
branch
from
a99893c to
cdc6048
Compare
|
Flaky tests detected in dc7851d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18710123365
|
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
ockham
added
Backport to WP 6.9 Beta/RC
Backport to Gutenberg RC
ockham
force-pushed
the
add/pattern-overrides-support-for-image-caption-attribute
branch
from
d590987 to
885f327
Compare
talldan
approved these changes
Oct 21, 2025
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
This works well in my testing. I think it could be considered a bug fix, as without this change users are still able to find a way around the caption restriction (add a caption after enabling overrides).
Making the Enable Overrides button work properly resolves that inconsistency.
ockham
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
force-pushed
the
add/pattern-overrides-support-for-image-caption-attribute
branch
from
885f327 to
dc7851d
Compare
ockham
deleted the
add/pattern-overrides-support-for-image-caption-attribute
branch
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
Contributor
Author
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Contributor
I don't think we need to backport it to a 2.5-year-old Gutenberg version, but I'll backport it to 21.9 😛 |
priethor
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the release/21.9 branch to get it included in the next release: c2ca71f |
Contributor
Author
Whatever happened to WordPress' promise of backwards-compatibility? I want my money back! 😠
Thank you! |
Contributor
|
The automatic backport to the See #72573 for more details. |
t-hamano
added
Backported to WP Core
Contributor
|
Thanks @t-hamano, I was just looking into that 🥇 |
priethor
removed
the
Backport to Gutenberg RC
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add Pattern Overrides support for the Image block's
captionattribute.Why?
Block Bindings support has been added for the
captionattribute, which means it should also be made available for Pattern Overrides.How?
By adding it to the
PARTIAL_SYNCING_SUPPORTED_BLOCKSarray.We previously considered inferring the list of block attributes supported by pattern overrides from the list of block attributes supported by block bindings from the server. However, we found that those lists aren't necessarily identical -- e.g. the Nav Link and Submenu blocks'
urlattribute is now supported by block bindings, but shouldn't be supported by pattern overrides. We thus decided to keep the separatePARTIAL_SYNCING_SUPPORTED_BLOCKSconst for now.Testing Instructions
trunk, where it isn't -- see screencasts below.)Screenshots or screencast