Add end to end tests for Fit Text#72406
Merged
jorgefilipecosta merged 9 commits intotrunkfrom Oct 20, 2025
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.2 MB ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/fit-text-end-to-end-test
branch
from
8018e91 to
d7a1bd3
Compare
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
|
Flaky tests detected in a07c89d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18654985615
|
jorgefilipecosta
added
[Type] Automated Testing
mcsf
approved these changes
Oct 17, 2025
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
I left some questions. I'm optimistically approving the PR assuming the questions don't require follow-up, but that's your call :)
Comment on lines
263
to
268
| const fontSize = await heading.evaluate( ( el ) => { | ||
| return window.getComputedStyle( el ).fontSize; | ||
| } ); | ||
|
|
||
| expect( fontSize ).toBeTruthy(); | ||
| expect( parseFloat( fontSize ) ).toBeGreaterThan( 0 ); |
Contributor
There was a problem hiding this comment.
Are we testing anything meaningful here? getComputedStyle returns a resolved value, and I can't think of a case in which we won't get a positive in this test.
For example, in this very browser tab's console, querying GitHub, I get:
window.getComputedStyle( document.querySelector('head') ).fontSize // "16px"
window.getComputedStyle( document.querySelector('meta') ).fontSize // "16px"Seems like a better test could be to verify that the computed size property matches the contents of styleElement, or at the very least that the size is greater than the document's base font size.
Member
Author
There was a problem hiding this comment.
You are right this assertion is not meaningful, I updated the test to assert that computed font size matches the contents of styleElement as suggested.
Comment on lines
305
to
313
| // Wait for fit text to calculate initially | ||
| await page.waitForFunction( | ||
| ( styleId ) => { | ||
| const style = document.getElementById( styleId ); | ||
| return style && style.textContent.trim().length > 0; | ||
| }, | ||
| `fit-text-${ fitTextId }`, | ||
| { timeout: 5000 } | ||
| ); |
Contributor
There was a problem hiding this comment.
Why do we need this manual waiting here, but not in other tests? In particular, the next test is also running in the front end.
Member
Author
There was a problem hiding this comment.
This the only test in the front end where fit text dynamically changes the font size (after the window resize), on the other tests we just load the post fit text computes and there are not additional changes. But we only need the second waitForFunction after the resize not this initial one so I removed it.
jorgefilipecosta
force-pushed
the
add/fit-text-end-to-end-test
branch
from
97eecc2 to
9e8921f
Compare
t-hamano
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org>
t-hamano
added a commit
that referenced
this pull request
Oct 23, 2025
…2e tests (#72584) * Add end to end tests for Fit Text (#72406) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> * Update: Disable font size when fit text is enabled and the opposite. (#72533) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> --------- Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements end to end tests for Fit Text.
Testing
Verify the end to end test is passing
npm run test:e2e -- fit-textApply this patch:
Rerun the end to end test
npm run test:e2e -- fit-textverify all the front end tests fail.Apply this patch:
Rerun the end to end test
npm run test:e2e -- fit-textverify all the editor tests fail.