PHP-only blocks: Auto-register blocks with block API version 3 by default#72047
Merged
PHP-only blocks: Auto-register blocks with block API version 3 by default#72047
Conversation
priethor
added
[Feature] Block API
priethor
force-pushed
the
add/auto-register-blocks-with-apiversion-3
branch
from
f2227aa to
89a450d
Compare
priethor
requested review from
ajitbohra,
fabiankaegy,
nerrad and
ntwb
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Oct 3, 2025
|
Size Change: +42 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 3, 2025
packages/block-library/src/index.js
Outdated
| const { name, apiVersion } = blockData; | ||
| registerBlockType( name, { | ||
| title: name, | ||
| apiVersion, |
Contributor
There was a problem hiding this comment.
why can't we just set it to v3 here , instead of changing the __unstableAutoRegisterBlocks variable?
Contributor
Author
There was a problem hiding this comment.
We can if you think that's better; I just thought to pass it already bumped to 3.
Contributor
There was a problem hiding this comment.
However, if the consumer explicitly defines the apiVersion other than 3 on the server side, the apiVersion on the client side and server side will not match, right? What do you think about this?
Contributor
Author
There was a problem hiding this comment.
It's the same as setting it always to 3 on the client. If it's a concern, then we shouldn't modify at all whatever got passed to the server's register_block_type.
Contributor
Author
There was a problem hiding this comment.
In 8e96635, I've changed it to check the apiVersion from the bootstrapped block type (not the registry, as correctly pointed out) before bumping it to 3.
youknowriad
reviewed
Oct 3, 2025
youknowriad
approved these changes
Oct 3, 2025
|
Flaky tests detected in c917886. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18222462709
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #71794, sets the default block API version of PHP-only auto-registered blocks to 3.
Why?
Since PHP-only blocks are a new thing, it doesn't make sense to allow this registration method to register new blocks with older api versions, especially since they can throw console warnings (see #70783)
How?
apiVersionto 3.api_versionis set during the PHP registration, it would have defaulted to 1, so with this, we are basically makingapi_versionoptional during the PHP registration.Testing Instructions
api_versionset, or set it to one:apiVersionwithwp.data.select('core/blocks').getBlockTypes().find(b => b.name === 'my-plugin/php-only-test-block').apiVersion, it should be set to3.