Skip to content

Update validation story to cover number field type #71980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 1 commit into from
Sep 30, 2025
Merged

Update validation story to cover number field type #71980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/dataviews/src/components/dataform/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ const ValidationComponent = ( {
url: string;
color: string;
integer: number;
number: number;
boolean: boolean;
customEdit: string;
categories: string[];
Expand All @@ -542,6 +543,7 @@ const ValidationComponent = ( {
url: 'https://example.com',
color: '#ff6600',
integer: 2,
number: 3.14,
boolean: true,
categories: [ 'astronomy' ],
countries: [ 'us' ],
Expand Down Expand Up @@ -616,6 +618,13 @@ const ValidationComponent = ( {

return null;
};
const customNumberRule = ( value: ValidatedItem ) => {
if ( ! /^\d+\.\d{2}$/.test( value?.number?.toString() ) ) {
return 'Number must have exactly two decimal places.';
}

return null;
};
const customBooleanRule = ( value: ValidatedItem ) => {
if ( value.boolean !== true ) {
return 'Boolean must be active.';
Expand Down Expand Up @@ -750,6 +759,15 @@ const ValidationComponent = ( {
custom: maybeCustomRule( customIntegerRule ),
},
},
{
id: 'number',
type: 'number',
label: 'Number',
isValid: {
required,
custom: maybeCustomRule( customNumberRule ),
},
},
{
id: 'boolean',
type: 'boolean',
Expand Down Expand Up @@ -850,6 +868,7 @@ const ValidationComponent = ( {
'url',
'color',
'integer',
'number',
'boolean',
'categories',
'countries',
Expand Down
Loading