DataViews grid layout: rounded corners for media#71543
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e7b1347. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17548494932
|
youknowriad
reviewed
Sep 8, 2025
| aspect-ratio: 1/1; | ||
| background-color: $white; | ||
| border-radius: $radius-medium; | ||
| overflow: hidden; |
Contributor
There was a problem hiding this comment.
Are there any "media" fields where we want scrollbars? Just asking to ensure we avoid regressions. Thinks like template previews could potentially fall in this category but not sure what the expectation there is.
Member
Author
There was a problem hiding this comment.
I think it'd be fine if we want to do that (we don't in the current templates):
Screen.Recording.2025-09-08.at.16.28.44.mov
youknowriad
approved these changes
Sep 8, 2025
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR makes sure the media field has rounded corners.
Why?
That's how we want it to be, like list and table layouts.
How?
By making sure the content doesn't overflow the container.
Testing Instructions
Visit the storybook (
npm run storybook:dev) and set the layout to grid. Verify the images have rounded corners.