Block Comments: Prevent commenting on empty blocks#71497
Merged
t-hamano merged 1 commit intoWordPress:trunkfrom Sep 11, 2025
Merged
Block Comments: Prevent commenting on empty blocks#71497t-hamano merged 1 commit intoWordPress:trunkfrom
t-hamano merged 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Sep 11, 2025
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! This works well for me.
adamsilverstein
added a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
This was referenced Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71496
Prevents users from adding comments to empty blocks (unmodified default blocks) and the block inserter placeholder, addressing unexpected behavior in the collaborative commenting feature.
Why?
Currently, the block commenting feature allows users to add comments to empty paragraph blocks and the block inserter placeholder, which feels unexpected and unintuitive. When a user clicks into an empty block or the inserter area, they shouldn't be able to add comments since there's no actual content to comment on.
This issue was identified as part of the Block Commenting iteration for WordPress 6.9 and affects the user experience of the collaborative workflows feature.
How?
The fix adds a check in the
AddCommentcomponent to detect unmodified default blocks using the existingisUnmodifiedDefaultBlockutility function from@wordpress/blocks. When an empty default block is selected, the comment form is not rendered, preventing users from adding comments to these blocks.Key changes:
isUnmodifiedDefaultBlockfrom@wordpress/blocksisEmptyDefaultBlockcheck in theuseSelecthookisEmptyDefaultBlockis trueTesting Instructions
Screenshots or screencast
Before
Before.mov
After
After.mov