Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 580f81f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17368683633
|
ockham
left a comment
There was a problem hiding this comment.
Makes sense. Thank you for the fix!
Fixes #39984.
The date/time being displayed in the Date block is currently using
gmdate():gutenberg/packages/block-library/src/post-date/index.php
Line 79 in a040815
This is incorrect. For comparison, refer to core's
get_post_time()function as used byget_the_date()as used in classic themes. It useswp_date()as follows:When the
$timezoneparameter is not passed towp_date()then it uses the current timezone as specified in the blog's settings.Testing
I added a Date block in a row in the Single template in Twenty Twenty-Five:
I also have my timezone set to America/Los Angeles:
The current time for me right now is 22:35 (10:35pm) on August 31st. In the block editor, I see this reflected correctly when showing the template in the block editor:
However, if I view the post on the frontend, I see September 1st, since that is the current date in UTC/GMT:
When I switch to the code in this branch so that
wp_date()is used instead, then I see the expected date of August 31st: