Conversation
| contents: read | ||
| if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }} | ||
| if: false | ||
| #if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }} |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in cb86ff8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17212441341
|
desrosj
left a comment
There was a problem hiding this comment.
Wanted to play deveil's advocate here.
- Do we know that tests will actually break?
- If so, how badly?
- What is the level of effort to fix them at the same time as upgrading?
My strong preference is to update all tests at the same time as upgrading so that the tests never fail or need to be disabled. Any gap between disabling tests and re-enabling them comes with a level of risk that we need to weigh.
|
@desrosj, I think that's the known issue from the previous attempt - #61521. As far as I know, the Gutenberg Mobile project is on hold for now, and not many of us have enough experience with its architecture or React Native to handle the required upgrades. cc @dcalhoun @oguzkocer |
|
@desrosj yep, as @Mamaduka mentioned, the Gutenberg Mobile project is not getting any attention at this time, and I've confirmed with the team that they're not planning to work on it actively. This also means that there won't be much capacity to work on this non-trivial React-19-compatible RN upgrade, which is a blocker to making these tests and Gutenberg Mobile work. I had some conversations with the team, and we agreed this is the best path forward for the web project. This also means that if there are any follow-up fixes or patches on the RN packages necessary, they will be done in the relevant branches and not in trunk. @desrosj just to be sure that I've answered your questions:
Yes, we've confirmed with upgrading to React 19, and making React 19 work with RN requires a non-trivial upgrade.
Quite broken as per #61521.
Fixing them means upgrading RN to a compatible version (v0.78 or newer), which I confirmed with the mobile team is a non-trivial upgrade and requires a lot of work that can't be prioritized at this time. |
|
I affirm what @Mamaduka and @tyxla shared. Upgrading React Native to fix the test failures is not a feasible option for the mobile team at this time. I feel @tyxla's summary in #71336 accurately describes the context and rationale for this action:
|
|
Thanks for clarifying! |
What?
Skipping the mobile unit tests.
Part of #71336.
Why?
As we're moving forward with the React 19 upgrade, they will inevitably break, so we're disabling them for the time being.
See #71336 for more info.
How?
Just skipping them.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None