Image: Don't allow convert to cover controls in contentOnly mode#71329
Merged
andrewserong merged 1 commit intotrunkfrom Aug 25, 2025
Merged
Conversation
andrewserong
added
[Type] Bug
andrewserong
changed the title
42 tasks
Mamaduka
approved these changes
Aug 25, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Makes sense. Thanks, @andrewserong!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for the quick review! 🙇 |
andrewserong
deleted the
fix/image-block-dont-allow-cover-controls-in-content-only-mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #65778
In the image block, hide the cover controls (Add text over image) when in contentOnly mode.
Why?
As discussed in #65778 (comment) the idea is that write mode is for editing existing content, not introducing new material such as captions. And for the case of these cover controls, it's a destructive action that replaces the Image block with a Cover block. Further, since we don't allow block transformations in write mode, I think that makes another argument for hiding them.
How?
Testing Instructions
trunkthere'll be an option to "Add text over image"Screenshots or screencast
In write mode (the pencil icon in the top toolbar)
In design mode, it should still be available: