Block Comments: Remove period in comment UI text

[mrleemon]

What?

Fix typo in comments.js

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before	After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mrleemon <leemon@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

Thanks for the PR!

My guess is that the dot doesn't represent a period, but rather an ellipsis. In other words, there's a dot missing.

Actual	Expected

What do you think?

[mrleemon]

@t-hamano Yes, I've thought about this. I have no problem creating a new PR with an …. Can anyone (@akasunil, @ellatrix) confirm this?

[t-hamano]

Probably it would be good to get the feedback from @WordPress/gutenberg-design.

Which is the expected text in the following texts?

• 7 more more replies.
• 7 more more replies..
• 7 more more replies...

[jasmussen]

This item is clickable, yes? Then I would expect no period at the end, i.e. 7 more replies

What do you think?

[t-hamano]

This item is clickable, yes?

Actually, this isn't a button 😅 You can click anywhere on the card to expand the comments.

1fe7c245e2715e67e7e56a17d5c84768.mp4

[jasmussen]

Ah, there's some work in progress there, I'd expect this to be a button that expands these, especially as discussons get very long these buttons will be even more important. To that end, I'd still omit the period, but also move forward with this as I assume more iterations on the feature itself in the future. Thanks for the clarification!

[akasunil]

Actually, this isn't a button 😅 You can click anywhere on the card to expand the comments.

This text lets users know there are more replies. On click, the board will focus and show all replies.

[t-hamano]

Thank you everyone for the feedback!

@mrleemon could you update the text to %s more replies (no period)?

[t-hamano]

LGTM!

[ramonjd]

LGTM - I just kicked off the tests again and will merge if they pass. Thank you!

[t-hamano]

It seems that we need to fix the linter error before merging.

@mrleemon can you run the following command in your local Gutenberg project to automatically apply the fix to the file?

npm run lint:js:fix -- --no-cache packages/editor/src/components/collab-sidebar/comments.js

This command should format the code like this:

diff --git a/packages/editor/src/components/collab-sidebar/comments.js b/packages/editor/src/components/collab-sidebar/comments.js
index cba138d357..b99aec4654 100644
--- a/packages/editor/src/components/collab-sidebar/comments.js
+++ b/packages/editor/src/components/collab-sidebar/comments.js
@@ -145,10 +145,7 @@ function Thread( {
                                                <VStack className="editor-collab-sidebar-panel__show-more-reply">
                                                        { sprintf(
                                                                // translators: %s: number of replies.
-                                                               _x(
-                                                                       '%s more replies',
-                                                                       'Show replies button'
-                                                               ),
+                                                               _x( '%s more replies', 'Show replies button' ),
                                                                thread?.reply?.length
                                                        ) }
                                                </VStack>