Correct padding for empty-state elements when <DataViews> is in a <Card>#70638
Merged
Correct padding for empty-state elements when <DataViews> is in a <Card>#70638
Conversation
p-jackson
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
9 tasks
|
Size Change: +46 B (0%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in efacdbf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16132281554
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up of #70567 where a number of changes were merged into the dataviews package.
One of the changes was tighter padding for
<DataViews>when placed within a<Card>. That change forgot to apply the tighter padding on the "no results" and "loading" elements that can exist within the dataview body too.Why?
We want consistent padding with dataviews so the elements always align nicely, even when the screen is small or the "no results" text is very long.
How?
Adds missing padding which should have been added in #70567.
No changelog entry is needed since it is covered by the existing one:
Testing Instructions
DataViews > With CardstorybookDataViews > DefaultstorybookTesting Instructions for Keyboard
Change only affects padding of static text.
Screenshots or screencast