Skip to content

Navigation Submenu Block: Add example preview#68378

Merged
carolinan merged 2 commits intoWordPress:trunkfrom
himanshupathak95:add/navigation-submenu-block-example
Jan 27, 2025
Merged

Navigation Submenu Block: Add example preview#68378
carolinan merged 2 commits intoWordPress:trunkfrom
himanshupathak95:add/navigation-submenu-block-example

Conversation

@himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Dec 30, 2024

Part of: #64707

What?

Add translatable example preview text in the Navigation Submenu block.

Testing Instructions

  • Navigate to a page or post editor
  • Click the inserter button (+)
  • Search for "Navigation Submenu"
  • Verify the block preview appears in the inserter with translatable text

Screenshot

image

@himanshupathak95 himanshupathak95 marked this pull request as ready for review December 30, 2024 06:02
@github-actions
Copy link

github-actions bot commented Dec 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement. [Feature] Style Book labels Jan 13, 2025
@carolinan carolinan enabled auto-merge (squash) January 24, 2025 05:08
auto-merge was automatically disabled January 24, 2025 05:49

Head branch was pushed to by a user without write access

@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from 881e055 to 17f41c1 Compare January 24, 2025 05:49
@himanshupathak95
Copy link
Contributor Author

The E2E Playwright - 2 test is passing locally but failing here, rebasing again to re-run the jobs.

@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from 17f41c1 to d8d0eea Compare January 24, 2025 06:35
@himanshupathak95 himanshupathak95 force-pushed the add/navigation-submenu-block-example branch from d8d0eea to ac263ac Compare January 27, 2025 04:53
@himanshupathak95
Copy link
Contributor Author

Hi @carolinan, Thanks for approving the PR.

The tests are now passing since they were fixed by #68872. This PR is now ready to be shipped 🚀

@carolinan carolinan merged commit b984ec9 into WordPress:trunk Jan 27, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 27, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
* Navigation Submenu Block: Add example preview

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
* Navigation Submenu Block: Add example preview

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Submenu Affects the Submenu Block - for submenus in navigation [Feature] Style Book [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants