Fix: Highlighted heading block breaks when moved into a group block #68342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56025
What?
As mentioned in #56025, When we add a heading or p tag with a color highlight into a group block. Then It break on the initial render.
Why?
contentRef.current
when we drop heading or p. We might be accessing the element before it is fully rendered. Which gives an undefined value and that undefined is passed down in the functions leading to this error.How?
contentRef.current
is passed down to the functions to calculate styles, Adding a check in the useMemo callback to only call thefillComputedColors
function if we have a ref.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
before.mov
After
after.mov