Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove %s from Lerna publish message #6827

Merged
merged 1 commit into from
May 18, 2018
Merged

Remove %s from Lerna publish message #6827

merged 1 commit into from
May 18, 2018

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented May 18, 2018

Description

When using Lerna in independent the %s global version number is not available as each package will be released with its own version number.

See https://github.com/lerna/lerna#--message--m-msg

How has this been tested?

Screenshots

Types of changes

Build Tooling change

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ntwb ntwb added the [Type] Build Tooling Issues or PRs related to build tooling label May 18, 2018
@ntwb ntwb requested a review from gziolo May 18, 2018 12:12
gziolo
gziolo approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for catching 👍

@ntwb ntwb merged commit 9f42151 into master May 18, 2018
@ntwb ntwb deleted the update/lerna-commit-message branch May 18, 2018 12:19
@mtias mtias added this to the 2.9 milestone May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ntwb @gziolo @mtias