Grid Visualizer: Improve observation logic #68230
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Package] Block editor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +152 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7561ed4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12461451693
|
talldan
approved these changes
Dec 23, 2024
| setGridInfo( getGridInfo( gridElement ) ); | ||
| } ); | ||
| mutationObserver.observe( gridElement, { | ||
| attributeFilter: [ 'style' ], |
There was a problem hiding this comment.
I wonder if 'class' should also be added to this list. Change block style variations or adding a custom classname could also result in a change of top padding/border.
|
Thanks for the PR! Sorry, I forgot to attach the video, so I uploaded it.
I think this is right, so I would like to add it. |
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
* Grid Visualizer: Improve observation logic * Add `class` to `attributeFilter` Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
@t-hamano, just letting you know #68842. I’d appreciate your 👀 on that one 🙇. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue found in this comment: #64425 (review)
What?
This PR makes the grid visualizer's frames match their actual child elements more accurately.
Why?
This component is used to draw the frames for the blocks inside it when the block is a grid layout type. This frame is re-rendered when the grid block or its children change size. However, when padding or borders are applied to a grid block, this frame may not match the actual child blocks:
How?
To resolve this mismatch, I made two changes:
MutationObserberto monitor changes to style attributes, so that the frame is re-rendered when, for example, the vertical padding changes.getGridInfo()function, include the border width for padding calculations.Testing Instructions
ResizeObservernor theMutationObserbercan detect the change. If you have an approach to solve this, please let me know.Screenshots or screencast
92d7b58f5c6f6f8c17476b0216dc9c86.mp4