Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PositionPanel: Add z-index control and position value adjustments #68123

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

Fixes: #67873

What?

This PR adds the option to set top, bottom, left, and right values along with the z-index when the position of a block is set to sticky.

Why?

Currently, there's no way to add the z-index and directional values which limits the capabilities of the block editor and emphasizes on the usage of Custom CSS to achieve the result. This has been properly described in the issue tagged above.

How?

The PR adds the required Block Controls for z-index and position values.

Testing Instructions

  1. Insert a Group block.
  2. Notice the z-index and directional options inside the position inspector controls.

Screenshots

Before After
Screenshot 2024-12-19 at 1 59 01 PM Screenshot 2024-12-19 at 1 58 06 PM

Screencast

1080p.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 19, 2024 08:38
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @burnuser.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: burnuser.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing adjustments to "sticky"
2 participants