Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Only override REST server for older WP versions #67779

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Mamaduka
Copy link
Member

What?

PR makes REST server override conditional and only applies it WP < 6.7. There's no need to override if WP already supports targetHints.

How?

Uses the get_user function for version check. This is more efficient than version checks.

Testing Instructions

None. Just confirm that the logic is correct.

Testing Instructions for Keyboard

Same.

@Mamaduka Mamaduka added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Performance Related to performance efforts labels Dec 10, 2024
@Mamaduka Mamaduka self-assigned this Dec 10, 2024
@Mamaduka Mamaduka requested a review from gziolo December 10, 2024 07:30
Copy link

github-actions bot commented Dec 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core and removed [Type] Performance Related to performance efforts labels Dec 10, 2024
Copy link

Flaky tests detected in 4a3d821.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12251410614
📝 Reported issues:

@Mamaduka Mamaduka merged commit 11f10fb into trunk Dec 10, 2024
69 of 79 checks passed
@Mamaduka Mamaduka deleted the update/rest-server-override branch December 10, 2024 09:07
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 10, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
)


Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants