Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome guide headline update #67654

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

benazeer-ben
Copy link
Contributor

What?

Fix for #67601

Why?

There is widows for each frame of the welcome guide.

How?

Updated the headline text as mentioned.

  • Welcome to the block editor > Welcome to the editor
  • Make each block your own > Customize each block
  • Get to know the block library > Explore all blocks
  • Learn how to use the block editor > Learn more

Testing Instructions

  • Go to page/post edit screen.
  • Make sure Welcome guide option is enable from page/post settings.
  • Check and verify each headlines of the welcome guide.
  • All are updated as mentioned

Screenshots or screencast

customise
explore
learnmore
welcome

Copy link

github-actions bot commented Dec 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <benazeer@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@annezazu
Copy link
Contributor

annezazu commented Dec 6, 2024

Thank you! Looks good to me.

@talldan
Copy link
Contributor

talldan commented Dec 6, 2024

@benazeer-ben Thanks for working on this. It looks like there are some automated tests that need to be updated.

It should be a straightforward matter of updating the strings to match the changes you've made, e.g. -

'Welcome to the block editor'

@talldan talldan added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience [Type] Copy Issues or PRs that need copy editing assistance and removed [Type] Enhancement A suggestion for improvement. labels Dec 6, 2024
@benazeer-ben
Copy link
Contributor Author

Hi @talldan

Thank you for pointing that out!

I’ve updated the automated tests to reflect the changes I made. The strings have been adjusted accordingly, and everything should now align with the current implementation.

Please let me know if there’s anything else I should address.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@talldan talldan merged commit 6c312f7 into WordPress:trunk Dec 6, 2024
60 of 62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants