Closed
Conversation
getdave
commented
Nov 28, 2024
Comment on lines
+217
to
+218
| // HACK FOR TESTING PURPOSES. | ||
| const isNavigationBlock = useSelect( |
Contributor
Author
There was a problem hiding this comment.
Do not ship with this in place.
getdave
commented
Nov 28, 2024
| clientIds={ contentClientIds } | ||
| /> | ||
| </PanelBody> | ||
| { ! isNavigationBlock && |
Contributor
Author
There was a problem hiding this comment.
We could make this condition some kind of private editor setting. We can then pass in the various blocks we want to enable this behaviour for.
|
Size Change: +47 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Contributor
|
Yes this is a simplified version of #66753 and it shows the open questions:
|
Contributor
Author
💯 and I shameless borrowed some code patterns from your PR there, aiming to distill out the smallest PR possible.
As I see it we should probably start by exploring this as a hardcoded list of blocks that "expose" a List View in contentOnly. We can do this via a private block editor setting which provides a list of blocks which should use this function.
As the list of blocks expands, we can use the above work to shape the correct API. It may be that blocks with controlled inner blocks can opt into some API that exposes a sub tree representation and also opts the block into I'm hesitant to try and come up with an all encompassing API first. @talldan also appears to be doing some related work in #67372 which might allow us to simplify some of this PR. |
Mamaduka
added
[Type] Enhancement
Contributor
Author
|
Closing in favour of #70977 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
WIP
Closes #65699
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-11-28.at.10-45-15.mp4