Prefer exact matches in Link Search results sorting #67367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
try/improve-link-search-weighting
branch
from
cb1f593 to
92fa46f
Compare
|
Flaky tests detected in 92fa46f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12071514942
|
draganescu
approved these changes
Nov 28, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
* Weight towards exact matches * Add additional test coverage Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Weight towards exact matches * Add additional test coverage Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes Link search results sorting to sort in favour of exact search term matches over sub matches
Closes #38121
Why?
When searching for a Post it's important that results are ordered to weight towards exact matches. If we don't do this then we end up in situations where a search for "News" will return:
...even though both "News" pages are logically more relevant to the search term. Histroically this has lead to strange results as reported in the Issue..
How?
Updates the client-side search sorting/ordering algorithm to weight towards exact matches over sub matches. This means if a search term matches a title token exactly it [the result] will "score" more highly in the weighting.
Testing Instructions
Testing Instructions for Keyboard
NewsNewspaperNews Flash NewsNewsScreenshots or screencast