Skip to content

Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2#67258

Merged
cbravobernal merged 3 commits intowp/6.7from
fix/composite-typeahead-6-7-2
Nov 25, 2024
Merged

Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2#67258
cbravobernal merged 3 commits intowp/6.7from
fix/composite-typeahead-6-7-2

Conversation

@cbravobernal
Copy link
Contributor

What?

Backports https://github.com/WordPress/gutenberg/pull/67212/files to wp/6.7 for WP 6.7.2 release.

* Composite.Typeahead: Restore functionality

* Add changelog

* Resurrect CompositeHover

* Update changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
@cbravobernal cbravobernal added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release labels Nov 24, 2024
@@ -15,6 +11,99 @@

### Bug Fixes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the changelog got messed while doing the cherry pick. As this will release a minor package. How should we update it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there have been similar cases in the past:

How about manually adding just these two entries to the Bug Fixes section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in 0bc540d

@github-actions
Copy link

github-actions bot commented Nov 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It seems that 0bc540d deleted the following entry that was originally present.

-   `FormFileUpload`: Prevent HEIC and HEIF files from being uploaded on Safari ([#67139](https://github.com/WordPress/gutenberg/pull/67139)).

Therefore, I have updated the Changelog again by 51dfa59. This should be correct.

@cbravobernal cbravobernal merged commit 9137a9f into wp/6.7 Nov 25, 2024
@cbravobernal cbravobernal deleted the fix/composite-typeahead-6-7-2 branch November 25, 2024 16:17
aaronjorbin added a commit to aaronjorbin/wordpress-develop that referenced this pull request Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs:

- PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086
- Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244
- Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508
- [6.7] Zoom in/out to correct location WordPress/gutenberg#66618
- Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258
- Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259
- Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121
- [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503
- iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713
- e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886
- Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s
- useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200

Co-authored-by: Aki Hamano <tetsuaki.hamano@gmail.com>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: David <david.arenas@automattic.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: PARTHVATALIYA <parthvataliya@git.wordpress.org>
Co-authored-by: Riad Benguella <benguella@gmail.com>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: Tropicalista <tropicalista@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: danielpost <danielpost@git.wordpress.org>
Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: mt8 <mt8biz@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: sathyapulse <sathyapulse@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: stokesman <presstoke@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
aaronjorbin added a commit to aaronjorbin/wordpress-develop that referenced this pull request Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs:

- PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086
- Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244
- Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508
- [6.7] Zoom in/out to correct location WordPress/gutenberg#66618
- Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258
- Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259
- Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121
- [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503
- iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713
- e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886
- Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s
- useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200

Co-authored-by: Aki Hamano <tetsuaki.hamano@gmail.com>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: David <david.arenas@automattic.com>
Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: PARTHVATALIYA <parthvataliya@git.wordpress.org>
Co-authored-by: Riad Benguella <benguella@gmail.com>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: Tropicalista <tropicalista@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: danielpost <danielpost@git.wordpress.org>
Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: mt8 <mt8biz@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: sathyapulse <sathyapulse@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: stokesman <presstoke@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs:

- PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086
- Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244
- Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508
- [6.7] Zoom in/out to correct location WordPress/gutenberg#66618
- Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258
- Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259
- Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121
- [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503
- iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713
- e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886
- Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s
- useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200

Reviewed-by audrasjb.

Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad.
Fixes #62889.



git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59762 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs:

- PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086
- Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244
- Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508
- [6.7] Zoom in/out to correct location WordPress/gutenberg#66618
- Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258
- Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259
- Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121
- [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503
- iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713
- e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886
- Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s
- useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200

Reviewed-by audrasjb.

Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad.
Fixes #62889.


Built from https://develop.svn.wordpress.org/branches/6.7@59762


git-svn-id: http://core.svn.wordpress.org/branches/6.7@59104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@t-hamano
Copy link
Contributor

Removing Backport to WP Minor Release label as this PR has already been merged into wp/6.7 branch.

@t-hamano t-hamano removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants