Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes margin right from wp-block-tag-cloud #66973

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

devansh016
Copy link
Contributor

@devansh016 devansh016 commented Nov 13, 2024

What?

When you set a Tag Cloud block to the "Outline" style, the spacing between the items is set both with a gap on the container and a margin-right on reach individual link element, resulting in uneven spacing between the items.
Resolves #66678

Why?

.wp-block-tag-cloud a has margin right property causing this.

Testing Instructions

  1. Insert a Tag Cloud block.
  2. Set it to the "Outline" style.
  3. Inspect it on the front-end, and verify that there's both a gap on the .wp-block-tag-cloud container and a margin-right on each link element, resulting in an uneven spacing between each item.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-11-13 at 9 45 20 PM

@devansh016 devansh016 marked this pull request as ready for review November 13, 2024 16:17
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jennajaehnig.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jennajaehnig.

Co-authored-by: devansh016 <devansh2002@git.wordpress.org>
Co-authored-by: andersnoren <anlino@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Cloud: Uneven spacing when set to the "Outline" style
1 participant