TextControl: Deprecate 36px default size #66745
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Changes look good 👍
In addition to this though, there are a lot of code snippets in Markdown files and Storybook stories across the repo that use TextControl, and all of them need the prop. Otherwise the devs referring to those snippets would be copy pasting deprecated code. (I added some clarification in the original issue's procedure checklist.)
| @@ -38,6 +39,13 @@ function UnforwardedTextControl( | |||
| const onChangeValue = ( event: ChangeEvent< HTMLInputElement > ) => | |||
| onChange( event.target.value ); | |||
|
|
|||
| // Add Warning for deprecated 36px size. | |||
There was a problem hiding this comment.
Comment seems unnecessary?
| // Add Warning for deprecated 36px size. |
Part of #65751
What?
Deprecate the 36px default size in TextControl.
Testing Instructions